On 05/02/16(Fri) 14:06, Jérémie Courrèges-Anglas wrote: > Martin Pieuchot <[email protected]> writes: > > > On 01/02/16(Mon) 13:15, Todd C. Miller wrote: > >> On Mon, 01 Feb 2016 19:56:01 +0100, > >> =?utf-8?Q?J=C3=A9r=C3=A9mie_Courr=C3=A8ges- > >> Anglas?= wrote: > >> > >> > intro(2) describes it as such: > >> > > >> > 59 ETOOMANYREFS Too many references: can't splice. Not used in OpenBSD. > >> > > >> > Obviously it *is* used, since rev. 1.1. FreeBSD and NetBSD also make > >> > use of it, but FreeBSD doesn't document it. > >> > > >> > I don't know whether the kernel code should keep on using it, here's > >> > a patch to fix the documentation: > >> > >> I think the correct thing to do here is fix the documentation. > > > > We could also return ENOBUFS in this case instead. That would > > correspond to the errors described in ip(4) (sadly setsockopt(2) is not > > really reflecting the code). > > > > Jérémie what other OSes report as errors for IP_ADD_MEMBERSHIP? > > I only looked at loonix-4.5-rc2 so far: ENOBUFS in this error case.
Then I think it's the way to go.
