On 25/02/16(Thu) 11:39, Mike Larkin wrote: > On Thu, Feb 25, 2016 at 03:05:21PM +0100, Martin Pieuchot wrote: > [...] > > - return 0; > > + return db_elf_sym_lookup(&db_symtab, symstr); > > } > > From what I can tell, db_lookup is only called one time in the tree. > Rather than replace db_lookup with a 1-line "return" that just calls another > function, should we replace the single call to db_lookup with a call to > db_elf_sym_lookup and just remove db_lookup entirely? If you go this > route, please remove the reference in db_sym.h as well.
That's a valid point, I have this change in one of my upcoming diffs. So unless I hear any objection I'll go ahead with this one and send the next cleaning diff. My goal is to stop having an abstraction layer on top of the ELF symbol format to be able to use some of the symbol properties. > Other than that, this diff reads ok. Thanks.
