> sys/scsi/st.c:1024 uses:
>
>> cmd->len != 0
>
> as a condition. However, cmd is of type struct scsi_rw_tape, and its len
> field is of type u_int8_t len[3]. Therefore, the condition is always
> true because len is treated as a pointer.

Indeed, this looks like an oversight and should probably be
_3btol(cmd->len) != 0.

Reply via email to