Index: crypt.c
===================================================================
RCS file: /cvs/src/lib/libc/crypt/crypt.c,v
retrieving revision 1.31
diff -u -p -r1.31 crypt.c
--- crypt.c     12 Sep 2015 14:56:50 -0000      1.31
+++ crypt.c     4 Apr 2016 02:57:09 -0000
@@ -7,15 +7,10 @@
 char *
 crypt(const char *key, const char *setting)
 {
-       if (setting[0] == '$') {
-               switch (setting[1]) {
-               case '2':
-                       return bcrypt(key, setting);
-               default:
-                       errno = EINVAL;
-                       return (NULL);
-               }
+       if (setting[0] == '$' && setting[1] == '2') {
+               return bcrypt(key, setting);
        }
+
        errno = EINVAL;
        return (NULL);
 }

> -----Original Message-----
> From: Michael McConville [mailto:mm...@mykolab.com]
> Sent: Sunday, April 03, 2016 23:54
> To: Héctor Luis Gimbatti <h...@etale.com.ar>
> Subject: Re: Minor style rewrite for crypt.c
>
> You'll need to check out the CVS repo and send a diff for things like this.
>
> Héctor Luis Gimbatti wrote:
> > Greetings,
> > The function crypt (/usr/src/lib/libc/crypt/crypt.c) might be rewritten as:
> >
> > char *
> > crypt(const char *key, const char *setting) {
> >         if (setting[0] == '$' && setting[1] == '2')
> >                 return bcrypt(key, setting);
> >         errno = EINVAL;
> >         return (NULL);
> >
> > }
> >
> >
> > --- HLG
> >

Reply via email to