Visa Hankala <v...@openbsd.org> wrote: > On Tue, May 17, 2016 at 02:02:37AM +0200, Kim Lidström wrote: > > Is this patch better? I have tested it by trying both cnmac0, cnmac1 and > > cnmac2 as rootdev and it seems to work properly. > > I also removed the outdated comment, changed the pointless text (Maybe > > it'd be more appropriate to remove it?) and changed a memcpy() to > > strlcpy(). > > Oh, I added that strncmp too! > > The patch is better now, thanks. I committed it with a few tweaks. > I kept the strcmp() in device_register() because the buffers are > null-terminated and because the code is supposed check if the strings > are equal (not if bootdev is a prefix of dev->dv_xname). >
Thanks!
