On 19 August 2016 at 11:49, Richard Procter <richard.n.proc...@gmail.com> wrote: > > The final patch in the pf series. Will commit when I do the previous one > in around 24 hours unless there are objections. > > > - pushes the 'field changed' guards into the 'change field' functions. > This lets us normalise many of the existing guards and eliminate lots of > code from pf_translate(). > > - while here, optimise pf_patch_32() a little. Relatively clean and gains > 25% speedup for a function that can be called four times per TCP segment. > I don't know if this matters in the big picture. > > - simplify pf_match_addr(). Compiler achieves the same optimisation; > I saw no difference in the assembly. > > > The 'working' for these appears at http://203.79.107.124/ under the > phase two heading. > > best, > Richard. >
I've looked through this diff and I believe it's correct. OK mikeb
