On Tue, Sep 27, 2016 at 07:44:03PM +0200, Mark Kettenis wrote:
> > Date: Tue, 27 Sep 2016 18:01:51 +0200
> > From: Alexander Bluhm <[email protected]>
> >
> > On Mon, Sep 26, 2016 at 11:39:29PM +0200, Mark Kettenis wrote:
> > > Since the tests succeed on amd64, and should succeed on other
> > > architectures, the diff re-enables this test.
> >
> > When running with "make regress" the test fails as the regress
> > target does not build the libraries.
> >
> > Usually I add an addidtional rule in such a case.
> >
> > ok?
>
> Other regress tests that build library solve this by having a
>
> regress: all
>
> target in the library Makefile. See lib/libc/cxa-exit for example.
>
> Here is a diff that does that. As a bonus it sets NOPROFILE=yes to
> avoid building a profiled library and also adds $OpenBSD$ markers.
>
> ok?
works for me; OK bluhm@
>
>
> Index: regress/libexec/ld.so/constructor/libaa/Makefile
> ===================================================================
> RCS file: /cvs/src/regress/libexec/ld.so/constructor/libaa/Makefile,v
> retrieving revision 1.1
> diff -u -p -r1.1 Makefile
> --- regress/libexec/ld.so/constructor/libaa/Makefile 1 Feb 2003 19:56:17
> -0000 1.1
> +++ regress/libexec/ld.so/constructor/libaa/Makefile 27 Sep 2016 17:39:56
> -0000
> @@ -1,3 +1,9 @@
> +# $OpenBSD$
> +
> LIB=aa
> SRCS= aa.C
> +NOPROFILE=yes
> +
> +regress: all
> +
> .include <bsd.lib.mk>
> Index: regress/libexec/ld.so/constructor/libab/Makefile
> ===================================================================
> RCS file: /cvs/src/regress/libexec/ld.so/constructor/libab/Makefile,v
> retrieving revision 1.2
> diff -u -p -r1.2 Makefile
> --- regress/libexec/ld.so/constructor/libab/Makefile 27 Sep 2016 06:52:50
> -0000 1.2
> +++ regress/libexec/ld.so/constructor/libab/Makefile 27 Sep 2016 17:40:25
> -0000
> @@ -1,6 +1,12 @@
> +# $OpenBSD$
> +
> LIB=ab
> SRCS= ab.C
> +NOPROFILE=yes
> CPPFLAGS=-I${.CURDIR}/../libaa
> LDADD=-L../libaa
> LDADD+=-laa
> +
> +regress: all
> +
> .include <bsd.lib.mk>
