Theo de Raadt(dera...@openbsd.org) on 2016.10.16 20:03:05 -0600: > > On Sun, Oct 16, 2016 at 02:55:39PM -0700, Philip Guenther wrote: > > > > > > Instead of using errno as a hidden argument to vfatal(), make it an > > > _actual_ argument named 'code', ala the errc/warnc family, and rename it > > > to vfatalc() to match the pattern set. > > > > > > ok?
i dont consider the use of errno to be a problem here, the same is done in log_warn() and its kind of consistent with warn(3) etc. > > > Philip Guenther > > > > > > > Isn't this code used elsewhere too? this variant of log.c is in sync in iked, httpd, relayd, snmpd, vmd and quite different to the other ones. if this change goes in here, please sync all these. > benno is in the process of unifying all the log.c versions, as much > as possible. i'll keep a pointer to this thread to consider later.
