Hello,

> more strictly here.  Drop the whole fragment state if IPv6 fragments
> appear which have invalid length, fragment-offset or more-fragment-bit.

    I like the idea being strict here. I don't like 'goto overlap_fragment'.
    the 'overlap_fragment' as a name of jump target is bit confusing. Comment
    talks about 'Non terminal fragments' and code jumps to 'overlap_fragment'
>       /* Non terminal fragments must have more fragments flag */
>       if (frent->fe_off + frent->fe_len < total && !frent->fe_mff)
> -             goto bad_fragment;
> +             goto overlap_fragment;

    how about using 'goto free_ipv6_frag' ? It better explains, what's
    going to happen.

sorry for bikeshedding
regards
sasha

Reply via email to