On Tue, Jan 03, 2017 at 12:57:59PM -0700, Todd C. Miller wrote:
> When qsort.c was de-registered, the register version of 'aa' was
> not removed. Since qsort() already contains casts of a to char *
> there's no need for a separate variable here.
I think it would be nicer to keep the char * a variable and remove
the (char *) casts instead.
bluhm
>
> - todd
>
> Index: lib/libc/stdlib/qsort.c
> ===================================================================
> RCS file: /cvs/src/lib/libc/stdlib/qsort.c,v
> retrieving revision 1.13
> diff -u -p -u -r1.13 qsort.c
> --- lib/libc/stdlib/qsort.c 13 Sep 2015 08:31:47 -0000 1.13
> +++ lib/libc/stdlib/qsort.c 3 Jan 2017 14:29:03 -0000
> @@ -81,12 +81,11 @@ med3(char *a, char *b, char *c, int (*cm
> }
>
> void
> -qsort(void *aa, size_t n, size_t es, int (*cmp)(const void *, const void *))
> +qsort(void *a, size_t n, size_t es, int (*cmp)(const void *, const void *))
> {
> char *pa, *pb, *pc, *pd, *pl, *pm, *pn;
> int cmp_result, swaptype;
> size_t d, r;
> - char *a = aa;
>
> loop: SWAPINIT(a, es);
> if (n < 7) {
