> Date: Sun, 16 Apr 2017 21:21:24 +0200 > From: Patrick Wildt <patr...@blueri.se> > > Hi, > > this diff disables the color diagnostics by default so that LLVM's lld > does not throw any ANSI sequences. > > ok?
Wouldn't it be better to just change lib/Support/Unix/Process.inc:terminalHasColors() to always return false? that should take care of the color stuff in all the different llvm tools. > diff --git a/gnu/llvm/tools/lld/ELF/DriverUtils.cpp > b/gnu/llvm/tools/lld/ELF/DriverUtils.cpp > index 5ba494d791d..36b4052d72a 100644 > --- a/gnu/llvm/tools/lld/ELF/DriverUtils.cpp > +++ b/gnu/llvm/tools/lld/ELF/DriverUtils.cpp > @@ -59,7 +59,7 @@ static bool getColorDiagnostics(opt::InputArgList &Args) { > auto *Arg = Args.getLastArg(OPT_color_diagnostics, > OPT_color_diagnostics_eq, > OPT_no_color_diagnostics); > if (!Arg) > - return Default; > + return false; > if (Arg->getOption().getID() == OPT_color_diagnostics) > return true; > if (Arg->getOption().getID() == OPT_no_color_diagnostics) > >