/sys/dev/isa/if_ex.c:619:7: error: logical not is only applied to the left hand
side of this bitwise operator [-Werror,-Wlogical-not-parentheses]
if (!CSR_READ_2(sc, IO_PORT_REG) & Done_bit)
^ ~
I think the expression was intended as below.
ok?
Index: if_ex.c
===================================================================
RCS file: /cvs/src/sys/dev/isa/if_ex.c,v
retrieving revision 1.45
diff -u -p -r1.45 if_ex.c
--- if_ex.c 22 Jan 2017 10:17:38 -0000 1.45
+++ if_ex.c 4 Jun 2017 19:42:46 -0000
@@ -616,7 +616,7 @@ ex_tx_intr(struct ex_softc *sc)
ifp->if_timer = 0;
while (sc->tx_head != sc->tx_tail) {
CSR_WRITE_2(sc, HOST_ADDR_REG, sc->tx_head);
- if (!CSR_READ_2(sc, IO_PORT_REG) & Done_bit)
+ if (!(CSR_READ_2(sc, IO_PORT_REG) & Done_bit))
break;
tx_status = CSR_READ_2(sc, IO_PORT_REG);
sc->tx_head = CSR_READ_2(sc, IO_PORT_REG);
--
Christian "naddy" Weisgerber [email protected]
