On Wed, Jul 05, 2017 at 09:10:52AM -0600, Theo de Raadt wrote:
I don't understand what you are fixing here.
It looks like you have rewritten it entirely, without cause.
It does the same in less code, that's not a fix but an improvement imho.
Even the manual page chunk: that is a warning to unprepared people
about an error they might make.
I was unsure as to whether this is more of a warning than just leaving
behaviour up to the implementation.
For the warning I agree one might keep it as is but on the other hand
I'm happy when the manual page tells me what a function does and why.
It doesn't hurt to be clear about it unless you really want it to mean
"take care or kittens may die".
