On Mon, Jul 31, 2017 at 07:53:21AM +0100, Jason McIntyre wrote: > On Mon, Jul 31, 2017 at 08:34:02AM +0200, Anton Lindqvist wrote: > > Hi, > > Some suggestions on how to improve the dhclient.conf(5) manual: > > > > - Shorten initial description, inspired by httpd.conf(5). > > > > - No need to mention the choice of parser implementation (recursive > > descent). > > > > - Do not use the word `end` twice in the sentence on comments, instead > > borrow a sentence from doas.conf(5). > > > > Comments? OK? > > > > yes, but one comment inline, and please wait for ken to look it over. > > > Index: dhclient.conf.5 > > =================================================================== > > RCS file: /cvs/src/sbin/dhclient/dhclient.conf.5,v > > retrieving revision 1.34 > > diff -u -p -r1.34 dhclient.conf.5 > > --- dhclient.conf.5 1 Sep 2016 20:06:52 -0000 1.34 > > +++ dhclient.conf.5 31 Jul 2017 06:32:28 -0000 > > @@ -43,22 +43,19 @@ > > .Nm dhclient.conf > > .Nd DHCP client configuration file > > .Sh DESCRIPTION > > -The > > .Nm > > -file contains configuration information for > > +is the configuration file for > > .Xr dhclient 8 . > > .Pp > > The > > .Nm > > -file is a free-form ASCII text file. > > -It is parsed by the recursive-descent parser built into > > -.Xr dhclient 8 . > > -The file may contain extra tabs and newlines for formatting purposes. > > +file is a free-form ASCII text file that may contain extra tabs and > > newlines for > > +formatting purposes. > > Keywords in the file are case-insensitive. > > Comments may be placed anywhere within the file (except within quotes). > > Comments begin with the > > .Sq # > > -character and end at the end of the line. > > +character and extend to the end of current the line. > > s/current the/the current/ ;)
Oops, my bad. Index: dhclient.conf.5 =================================================================== RCS file: /cvs/src/sbin/dhclient/dhclient.conf.5,v retrieving revision 1.34 diff -u -p -r1.34 dhclient.conf.5 --- dhclient.conf.5 1 Sep 2016 20:06:52 -0000 1.34 +++ dhclient.conf.5 31 Jul 2017 07:08:52 -0000 @@ -43,22 +43,19 @@ .Nm dhclient.conf .Nd DHCP client configuration file .Sh DESCRIPTION -The .Nm -file contains configuration information for +is the configuration file for .Xr dhclient 8 . .Pp The .Nm -file is a free-form ASCII text file. -It is parsed by the recursive-descent parser built into -.Xr dhclient 8 . -The file may contain extra tabs and newlines for formatting purposes. +file is a free-form ASCII text file that may contain extra tabs and newlines for +formatting purposes. Keywords in the file are case-insensitive. Comments may be placed anywhere within the file (except within quotes). Comments begin with the .Sq # -character and end at the end of the line. +character and extend to the end of the current line. .Pp The .Nm
