On Thu, Oct 05, 2017 at 08:08:32PM +0000, Christian Weisgerber wrote:
> Admittedly, this is cosmetic:
> Use the modern POSIX idiom "-exec ... {} +" instead of find|xargs.
> ok?
> 
> Index: include/Makefile
> ===================================================================
> RCS file: /cvs/src/include/Makefile,v
> retrieving revision 1.219
> diff -u -p -r1.219 Makefile
> --- include/Makefile  17 Apr 2017 15:53:21 -0000      1.219
> +++ include/Makefile  5 Oct 2017 19:35:58 -0000
> @@ -100,10 +100,9 @@ includes:
>               cd ${.CURDIR}/$$i && ${RUN_MAKE}; \
>       done
>       chown -RP ${BINOWN}:${BINGRP} ${DESTDIR}/usr/include
> -     find ${DESTDIR}/usr/include -type f -print0 | \
> -             xargs -0r chmod a=r
> -     find ${DESTDIR}/usr/include \( -type d -o -type l \) -print0 | \
> -             xargs -0r chmod -h u=rwx,go=rx
> +     find ${DESTDIR}/usr/include -type f -exec chmod a=r {} +
> +     find ${DESTDIR}/usr/include \( -type d -o -type l \) -exec \
> +             chmod -h u=rwx,go=rx {} +
>  
>  copies:
>       @echo copies: ${LDIRS}
> -- 
> Christian "naddy" Weisgerber                          na...@mips.inka.de
> 
FWIW, I've suggested this a while ago already:
https://marc.info/?l=openbsd-tech&m=149649423503939&w=2

Reply via email to