Kapetanakis Giannis(bil...@edu.physics.uoc.gr) on 2017.11.29 11:40:41 +0200: > On 28/11/17 17:06, Sebastian benoit wrote: > > Hi, > > > > your diff looks good, but i would rather do it the way bgpd/bgpctl do it: > > > > there the default is? /var/run/bgpd.sock.<rdomain> where <rdomain> is the > > routing domain bgpctl is running in.? To administer bgpd(8) in a different > > routing domain, run bgpctl in said routing domain. > > > > i.e. it detects the rdomain at startup, bgpctl does the same. > > > > Can you do that in relayd? It was commited there in sometime in summer. > > > > /Benno > > I followed snmpd way. > > My first diff was with -s command line option (ospfd, ldpd, iscsid, slaccd, > ripd way). > Then I changed it to relayd.conf socket option cause I saw a comment from > Reyk on an older thread that this is the way to go. > https://marc.info/?l=openbsd-tech&m=148840138521470&w=2 > > I don't think locking on rdomain is good in relayd since someone might want > to run multiple daemons on same rdomain. With bgpd this is not a requirement.
well, i was thinking of having both the option and the automatic .<number>. anyway, i commited your diff. Thanks. > Anyway if the patch is ok I believe it should go in because this feature is > really needed by many people. > Then later on if a universal way is decided on handling control sockets it > should be changed on all daemons > not following that decision. > > G >
