The client_addr_init never returns anything but 0, and this value isn't checked as well, so just make it void.
Okay? -- WBR, Vadim Zhukov Index: ldapclient.c =================================================================== RCS file: /cvs/src/usr.sbin/ypldap/ldapclient.c,v retrieving revision 1.39 diff -u -p -r1.39 ldapclient.c --- ldapclient.c 30 May 2017 09:33:31 -0000 1.39 +++ ldapclient.c 6 Dec 2017 15:28:12 -0000 @@ -54,7 +54,7 @@ int client_build_req(struct idm *, struc int client_search_idm(struct env *, struct idm *, struct aldap *, char **, char *, int, int, enum imsg_type); int client_try_idm(struct env *, struct idm *); -int client_addr_init(struct idm *); +void client_addr_init(struct idm *); int client_addr_free(struct idm *); struct aldap *client_aldap_open(struct ypldap_addr_list *); @@ -94,6 +94,6 @@ client_aldap_open(struct ypldap_addr_lis } -int +void client_addr_init(struct idm *idm) { struct sockaddr_in *sa_in; @@ -127,8 +127,6 @@ client_addr_init(struct idm *idm) /* not reached */ } } - - return (0); } int