On Tue, Dec 26 2017, "Todd C. Miller" <todd.mil...@sudo.ws> wrote: > I was investigating what is needed to add WARNINGS=Yes to ksh's > Makefile. There are a lot of shadowed variable warnings. Some are > easy to fix, others are due to poorly chosen global variable names. > Specifically, "options" and "path". I've renamed "options" to > "sh_options" since it holds the shell options and "path" to > "search_path". > > I'm open to suggestions of other names but with this diff ksh is > -Wshadow clean.
LGTM, ok jca@ -- jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE
