On 2018/03/18 18:32, Jason McIntyre wrote: > On Sun, Mar 18, 2018 at 03:05:26PM +0100, Klemens Nanni wrote: > > Some of these are wrong or sound odd when reading. The fact that the > > entire configuration value as well as all its options are purely > > optional is stated more than once, both in rtadvd(8) and rtadvd.conf(5), > > so I'd like to stop repeating it for every block of options.
this loses information, namely which sections do *not* have this message. some of the options are "leave this out and it will choose a default", others are "leave this out and it will not be set". as such I'm mostly not in favour. > i'm in favour of this diff. one point though: > > > Index: rtadvd.conf.5 > > =================================================================== > > RCS file: /cvs/src/usr.sbin/rtadvd/rtadvd.conf.5,v > > retrieving revision 1.38 > > diff -u -p -r1.38 rtadvd.conf.5 > > --- rtadvd.conf.5 25 Aug 2016 09:41:13 -0000 1.38 > > +++ rtadvd.conf.5 18 Mar 2018 14:01:47 -0000 > > @@ -73,9 +73,6 @@ Note that almost all items have default > > If you omit an item, the default value of the item will be used. > > .Pp > > There are two items which control the interval of sending router > > advertisements. > > -These items can be omitted, then > > -.Nm rtadvd > > -will use the default values. > > .Bl -tag -width indent > > .It Cm \&maxinterval > > (num) The maximum time allowed between sending unsolicited > > @@ -88,7 +85,7 @@ and no greater than 1800 seconds. > > (num) The minimum time allowed between sending unsolicited multicast > > router advertisements > > .Pq unit: seconds . > > -The default value is the one third of value of > > +The default value is one third of the value of this change is a clear improvement. > > .Cm maxinterval . > > Its value must be no less than 3 seconds and no greater than .75 * > > the value of > > @@ -97,9 +94,6 @@ the value of > > .Pp > > The following items are for ICMPv6 router advertisement message > > header. > > -These items can be omitted, then > > -.Nm rtadvd > > -will use the default values. > > .Bl -tag -width indent > > .It Cm \&chlim > > (num) The value for Cur Hop Limit field. > > @@ -151,10 +145,9 @@ The default value is 0, which means unsp > > .Pp > > The following items are for ICMPv6 prefix information option, > > which will be attached to router advertisement header. > > -These items can be omitted, then > > .Nm rtadvd > > -will automatically get appropriate prefixes from the kernel's routing > > table, > > -and advertise the prefixes with the default parameters, unless the > > +will automatically advertise appropriate prefixes from the kernel's routing > > +table, unless the > > .Cm noifprefix > > flag is specified. > > you are potentially changing meaning here (i say potentially because i'm > unsure how it all works). still, i suspect you could remove the entire > paragraph: > > These items can be omitted, then rtadvd will automatically > get appropriate prefixes from the kernel's routing table, > and advertise the prefixes with the default parameters, > unless the noifprefix flag is specified. > > because i think it is trying to say to say the same thing (everything is > optional) but adding in the complexity of noifprefix. I think I'd leave that paragraph as it was. > i'd be tempted to make one other change: > > - It obeys the famous termcap(5) file format. Each line in > + It obeys the infamous termcap(5) file format. Each line in yes!
