On Tue, Mar 27, 2018 at 9:30 PM David Gwynne <da...@gwynne.id.au> wrote:
> On Thu, Mar 15, 2018 at 03:25:46PM +0100, Martin Pieuchot wrote: > > On 14/03/18(Wed) 13:00, David Gwynne wrote: > > > this adds transmit mitigation back to the tree. > > > > > > it is basically the same diff as last time. the big difference this > > > time is that all the tunnel drivers all defer ip_output calls, which > > > avoids having to play games with NET_LOCK in the ifq transmit paths. > > > > Comments inline. > > > > > + if (ifq_len(ifq) >= min(4, ifq->ifq_maxlen)) { > > > > Why 4? DragonFly recently bumped `ifsq_stage_cntmax' to 16. Did you > > try other values? They also have an XXX comment that this value should > > be per-interface. Why? > > their default was 4, and they'd done some research on it. if they > moved to 16 there would be a reason for it. Would it be this commit? https://marc.info/?l=dragonfly-commits&m=151401707632544&w=2 Comments include test data. Michael