On Tue, Apr 03, 2018 at 10:20:42PM -0600, Theo de Raadt wrote: > Michael W. Bombardieri <m...@ii.net> wrote: > > > Hello, > > > > switchd can just use memset instead of mixing memset with bzero. > > But does the util.c change need to be sync'ed with other tools? > > There are 418 calls to bzero in *bin/*/*c > > bcopy isn't going to be removed from libc, and frankly it is > diomatically simpler. > > Would you believe in 15 years ago we have found calls where c and len > were swapped, making it a no-op -- in security sensitive software? Nice. > > So I don't see the specific value in your proposal.
I agree, bzero is simpler and easier to grep for. But then grep'ing is more complicated if you mix bzero and memset, so I guess it makes sense to use one or the other at least within the same file.
