This variable is unused on arm64.  Inherited from armv7 where it still
functions somewhat.  I suppose this used to set the speed of the
serial console but nowadays it only sets the default speed that we use
when the device tree doesn't set it.  I propose to remove it on armv7
too.  Using 115200 as a default like we do on arm64 should work just
fine.  I've not seen any armv7 or arm64 hardware that uses 9600 by
default.  If we want a mechanism to set the default speed we should
have the bootloader tweak the device tree instead.

ok?


Index: arch/arm64/arm64/machdep.c
===================================================================
RCS file: /cvs/src/sys/arch/arm64/arm64/machdep.c,v
retrieving revision 1.34
diff -u -p -r1.34 machdep.c
--- arch/arm64/arm64/machdep.c  28 May 2018 19:39:15 -0000      1.34
+++ arch/arm64/arm64/machdep.c  28 May 2018 19:43:19 -0000
@@ -1135,7 +1135,6 @@ remap_efi_runtime(EFI_PHYSICAL_ADDRESS s
                printf("SetVirtualAddressMap failed: %lu\n", status);
 }
 
-int comcnspeed = B115200;
 char bootargs[256];
 
 void
@@ -1194,12 +1193,6 @@ process_kernel_args(void)
                        break;
                case 's':
                        fl |= RB_SINGLE;
-                       break;
-               case '1':
-                       comcnspeed = B115200;
-                       break;
-               case '9':
-                       comcnspeed = B9600;
                        break;
                default:
                        printf("unknown option `%c'\n", *cp);

Reply via email to