On Tue, Jun 19, 2018 at 03:59:24PM +0100, Stuart Henderson wrote:
> On 2018/06/18 08:53, Remi Locherer wrote:
> > Index: ospfd.h
> > ===================================================================
> > RCS file: /cvs/src/usr.sbin/ospfd/ospfd.h,v
> > retrieving revision 1.100
> > diff -u -p -r1.100 ospfd.h
> > --- ospfd.h 11 Feb 2018 02:27:33 -0000 1.100
> > +++ ospfd.h 12 Jun 2018 20:41:43 -0000
> ...
> > -struct ifaddrdel {
> > +struct ifaddr {
> > struct in_addr addr;
> > + struct in_addr mask;
> > + struct in_addr dst;
> > unsigned int ifindex;
> > };
>
> I think it would be better to use a different name.
>
> Even if there's no actual conflict as if_var.h isn't pulled in, this is
> renaming this struct to "struct ifaddr" is at least confusing.
Oh yes, that is unfortunate.
What would be a better name for this struct?
iface_addr maybe? Or if_addrmask?
