On Sun, Jun 24, 2018 at 10:29:55PM +0200, Klemens Nanni wrote: > On Sun, Jun 24, 2018 at 10:09:26PM +0200, Florian Obser wrote: > > I don't understand why it's equivalent. > > > > prefixlen() seems to operate on so_mask while the only caller of > > inet6_makenetandmask() passes in so_dst. > > > > Assuming it is equivalent, inet6_makenetandmask() is now missnamed and > > I think we should just get rid of it. We can just call prefixlen() > > directly, the diff turns inet6_makenetandmask() into a weird wrapper > > around prefixlen(). Note that sep can't be NULL, so plen can't be > > NULL. > `sep' is NULL everytime the address string passed on the command line > does not contain "/". so `plen' is NULL and we set the prefixlen as it > wasn't specified in the first place. >
oops, yes, I missread the calling side, sorry. -- I'm not entirely sure you are real.