Hi,

The field ps_uvactive in `struct process` is unused.

Generally, for checking if unveil is active, checks are done on
(ps_uvvcount != 0) or (ps->ps_uvpaths != NULL).

I assume the field is a left over from previous developpment.

The kernel still build fine without it.

Thanks.
-- 
Sebastien Marie


Index: sys/proc.h
===================================================================
RCS file: /cvs/src/sys/sys/proc.h,v
retrieving revision 1.253
diff -u -p -r1.253 proc.h
--- sys/proc.h  20 Jul 2018 21:57:26 -0000      1.253
+++ sys/proc.h  28 Jul 2018 17:46:01 -0000
@@ -204,7 +204,6 @@ struct process {
        size_t ps_uvvcount;             /* count of unveil vnodes held */
        size_t ps_uvncount;             /* count of unveil names allocated */
        int ps_uvshrink;                /* do we need to shrink vnode list */
-       int ps_uvactive;                /* is unveil active */
        int ps_uvdone;                  /* no more unveil is permitted */
        int ps_uvpcwdgone;              /* need to reevaluate cwd unveil */
 

Reply via email to