Re: Remove unused variable in usr.bin/openssl/apps.c

[Theo Buehler]

On Thu, Aug 16, 2018 at 05:56:47PM +0200, Ingo Schwarze wrote:
[..]
> this commit seems wrong to me.

I agree. Thanks for paying attention, Ingo. This commit should be
reverted.

I think this is a bug that was introduced in r1.45 when free guards were
removed, a few of them a bit too aggressively. One of the suspicious
ones was already reverted, but his hunk has remained and should be
reverted, too:

@@ -2075,8 +2063,8 @@ policies_print(BIO *out, X509_STORE_CTX *ctx)

        nodes_print(out, "Authority", X509_policy_tree_get0_policies(tree));
        nodes_print(out, "User", X509_policy_tree_get0_user_policies(tree));
-       if (free_out)
-               BIO_free(out);
+
+       BIO_free(out);
 }