Re: pfsync: avoid a recursion on PF_LOCK

[Alexandr Nedvedicky]

On Tue, Oct 02, 2018 at 01:14:16AM +0200, Alexander Bluhm wrote:
> On Thu, Sep 27, 2018 at 06:34:45PM +0200, Alexandr Nedvedicky wrote:
> > OK to pfsync change?
> 
> OK bluhm@, just two style nits
> 
> > +           if ((e = ip_output(m, NULL, NULL, IP_RAWOUTPUT, &sc->sc_imo,
> > +               NULL, 0)) == 0)
> 
> Usually we call the error variable "error".
> 
> > +   if (mq_enqueue(&pfsync_mq, m) != 0) {
> > +           pfsyncstat_inc(pfsyncs_oerrors);
> > +           DPFPRINTF(LOG_DEBUG, "mq_enqueue() @ %s failed, queue full\n",
> > +               __func__);
> > +   }
> > +   else
> 
> The } and else should be on the same line.

    thanks for spotting those nits.

regards
sashan