Stuart Henderson <[email protected]> wrote:
> On 2018/10/24 17:38, Denis Fondras wrote:
> > I have peers with description containing spaces but bgplg won't accept that
> > by
> > default.
> >
> > I'd like some comments on that diff.
> > It is OK for bgplgsh (show ip bgp in "Peer 1" feels OK) but not for bgplg
> > as I
> > have to quote the peer description in the input box (feels rather
> > unnatural).
>
> it feels like allowing " in allowed characters for the CGI is starting
> to open a can of worms..
>
> personally I think I'd change the descriptions to avoid spaces.
I also think it is very dangerous, and I don't know why people put
spaces into those names.
Yet I see it all the time. Maybe our documentation needs to change,
and also the damn examples.
I see people struggling all the time, and I don't see why we fix this
through example
The problem starts in the example:
group "ibgp mesh v4" {
...
descr "IPv4 Transit Provider A"
etc