On Tue, Dec 11, 2018 at 11:00:30PM +0100, Marc Espie wrote: > Ah, so actually just > rm -f ${SUDO_CLEAN} > > should be fine ?
Regress jumps from root to non-root in a very inconsistent way. It could be improved, but that would be a lot of work. The result will not be perfect as tests have very different needs for permissions. So I would recommend to leave it as it is unless someone volunteers to refactor all the tests. If a test creates a file as root with an ugly ${SUDO} hack, it should use the same hack to clean it. Then the test is self contained. Care should be taken that the make clean hack does not affect the make build. So I like espie@'s suggestion to try rm first without ${SUDO} for people running make build, and then with ${SUDO} for people who have left overs from testing. bluhm