On Tue, Jan 01, 2019 at 10:30:55PM +0100, Remi Locherer wrote:
> Hi tech,
>
> when removing an interface from ospdf.conf and doing a reload other
> OSPF routers should get a router LSA update. Then they can remove the
> affected route. But currently this does not happen. The affected route
> might be used by other routers a long time after removing it from the
> config (until the LSA ages out).
>
> Below diff fixes this.
>
> OK?
Makes sense, OK claudio@
> Index: ospfd.c
> ===================================================================
> RCS file: /cvs/src/usr.sbin/ospfd/ospfd.c,v
> retrieving revision 1.102
> diff -u -p -r1.102 ospfd.c
> --- ospfd.c 28 Dec 2018 19:25:10 -0000 1.102
> +++ ospfd.c 1 Jan 2019 21:23:38 -0000
> @@ -827,7 +827,7 @@ merge_interfaces(struct area *a, struct
>
> /* problems:
> * - new interfaces (easy)
> - * - deleted interfaces (needs to be done via fsm?)
> + * - deleted interfaces
> * - changing passive (painful?)
> */
> for (i = LIST_FIRST(&a->iface_list); i != NULL; i = ni) {
> @@ -842,6 +842,7 @@ merge_interfaces(struct area *a, struct
> rde_nbr_iface_del(i);
> LIST_REMOVE(i, entry);
> if_del(i);
> + dirty = 1; /* force rtr LSA update */
> }
> }
>
>
--
:wq Claudio
