> Date: Sun, 6 Jan 2019 21:46:01 -0600 > From: Amit Kulkarni <amit.o...@gmail.com> > > > > Even on amd64, I won't be able to test, because of missing hardware. > > > If you think something is wrong, please will you let me have your > > > feedback? > > > > I'm a bit stunned at the zeal to push untested diffs into the tree > > > > (you didn't ask anyone to test it for you) > > I requested for critical review or feedback in the initial email, to > know if I am going down the right path. If the approach is ok, then > I was planning to sit down to try converting all the straightforward > of timeout_add() to timeout_add_msec() calls in the tree, then a > review again, before finally requesting a test run.
You can't do these conversions without understanding the code. In particular, timeout_add(t, 1) could mean sleep for 1/HZ seconds *or* sleep as short as possible. It is actually most likely the latter, in which case coverting to timeout_add_msec() makes no sense.
