On Wed, Mar 27, 2019 at 02:17:03AM +0100, Alexandr Nedvedicky wrote: > tedu@ has planted idea for diff below here [1]. That particular email is part > of thread [2], where various cleanup/unconfigure options for PF are discussed. > To keep progressing in small steps I've decided to factor out the first diff > here, which introduces '-FR' (a.k.a. reset settings) for pfctl(8). A bit late, but I generally agree on "reset" and reusing `-F'.
Diff looks sane to me, two comments: > -Flush all of the above. > +Flush all of the above (+ reset settings). This is fine as is, I think. > +void pfctl_restore_defaults(int, int); Why not simply pfctl_reset()?