On 9.9.2013. 22:07, Mike Belopuhov wrote:
> On 9 September 2013 21:48, Brad Smith <b...@comstyle.com> wrote:
> > Here is a diff to enable the checksum offload support for ix(4).
> >
> > Looking for any testing.
> >
> 
> last time i checked this broke ospf traffic.  please make sure at least
> ip/tcp, ip/udp, ip/icmp, ip/ip, ip/gre, ip/esp, ip/ah and ip/ospf work fine
> with this.

With checksum offloading enabled on the ix(4) I got ~20% performance
improvement with relayd(8) using socket splicing.  I think its worth to
enable this feature by default.

I also did my homework and tested all requested protocols:

                IPv4    IPv6    4over6  6over4
ip/tcp          check   check
ip/udp          check   check
ip/icmp         check   check
ip/ip           check   check   check   check
ip/gre          check   check   check   check
ip/esp          check   check
ip/ospf         check   check
nfs v2          check   -
nfs v3          check   -

I used the following card for testing:
ix0 at pci3 dev 0 function 0 "Intel 82599" rev 0x01: msi, address 
xx:xx:xx:xx:xx:xx

Looking for further testing or any OK?

Bye,
Jan

Index: sys/dev/pci/if_ix.c
===================================================================
RCS file: /cvs/src/sys/dev/pci/if_ix.c,v
retrieving revision 1.157
diff -u -p -r1.157 if_ix.c
--- sys/dev/pci/if_ix.c 10 Apr 2019 09:55:02 -0000      1.157
+++ sys/dev/pci/if_ix.c 27 Jul 2019 19:50:04 -0000
@@ -1678,9 +1678,7 @@ ixgbe_setup_interface(struct ix_softc *s
        ifp->if_capabilities |= IFCAP_VLAN_HWTAGGING;
 #endif
 
-#ifdef IX_CSUM_OFFLOAD
        ifp->if_capabilities |= IFCAP_CSUM_TCPv4 | IFCAP_CSUM_UDPv4;
-#endif
 
        /*
         * Specify the media types supported by this sc and register

Reply via email to