On Mon, Sep 23, 2019 at 06:23:32PM -0400, Ted Unangst wrote:
> snake and worm draw boxes, but they can be prettier by using the default
> style, which will use line drawing instead of ugly -*| characters.
> 
> should do the right thing on a vt100, but only tested in xterm.

It looks much prettier in an xterm but in the system console I'm
getting question marks.  Is that a limitation of the terminal or
am I missing the glyphs?  Dunno if this is the expected behavior
but it is uglier than what we had before.

Also, you forgot to delete the prototype for drawbox().

> Index: snake/snake.c
> ===================================================================
> RCS file: /home/cvs/src/games/snake/snake.c,v
> retrieving revision 1.34
> diff -u -p -r1.34 snake.c
> --- snake/snake.c     28 Jun 2019 13:32:52 -0000      1.34
> +++ snake/snake.c     13 Sep 2019 17:05:19 -0000
> @@ -450,23 +450,8 @@ setup(void)
>               pchar(&snake[i], SNAKETAIL);
>       }
>       pchar(&snake[0], SNAKEHEAD);
> -     drawbox();
> +     border(0, 0, 0, 0, 0, 0, 0, 0);
>       refresh();
> -}
> -
> -void
> -drawbox(void)
> -{
> -     int i;
> -
> -     for (i = 1; i <= ccnt; i++) {
> -             mvaddch(0, i, '-');
> -             mvaddch(lcnt + 1, i, '-');
> -     }
> -     for (i = 0; i <= lcnt + 1; i++) {
> -             mvaddch(i, 0, '|');
> -             mvaddch(i, ccnt + 1, '|');
> -     }
>  }
>  
>  void
> Index: worm/worm.c
> ===================================================================
> RCS file: /home/cvs/src/games/worm/worm.c,v
> retrieving revision 1.39
> diff -u -p -r1.39 worm.c
> --- worm/worm.c       24 Aug 2018 11:14:49 -0000      1.39
> +++ worm/worm.c       13 Sep 2019 16:51:39 -0000
> @@ -122,7 +122,7 @@ main(int argc, char **argv)
>       }
>       stw = newwin(1, COLS-1, 0, 0);
>       tv = newwin(LINES-1, COLS-1, 1, 0);
> -     box(tv, '*', '*');
> +     box(tv, 0, 0);
>       scrollok(tv, FALSE);
>       scrollok(stw, FALSE);
>       wmove(stw, 0, 0);
> 

Reply via email to