On Wed, Jan 01, 2020 at 11:21:45AM -0500, Todd Mortimer wrote:
> On Thu, Jan 02, 2020 at 02:41:11AM +1100, Jonathan Gray wrote:
> > On Wed, Jan 01, 2020 at 09:53:39AM -0500, Todd Mortimer wrote:
> > > My CPU has a CCP that isn't in the known list, so add it and tell ccp
> > > about it.
> > >
> > > Tested on Ryzen 3900x.
> > >
> > > ok?
> > >
> > > Will commit a pcidevs regen immediately after.
> >
> > Are your cpu lines in dmesg 17-3* or 17-7*?
> > Ryzen 3900x should be model 7X.
>
> 17-71-00.
>
> cpu0: AMD Ryzen 9 3900X 12-Core Processor, 3792.88 MHz, 17-71-00
>
> I assume then change the constant bits to 17_7X and 17h/7xh ?
Yes, unless that device id is also known to appear on earlier
models as well, in which case the first appearance is used.
>
> >
> > >
> > >
> > > diff --git a/sys/dev/pci/ccp_pci.c b/sys/dev/pci/ccp_pci.c
> > > index 2259594644b..c8dcc8750fc 100644
> > > --- a/sys/dev/pci/ccp_pci.c
> > > +++ b/sys/dev/pci/ccp_pci.c
> > > @@ -47,6 +47,7 @@ static const struct pci_matchid ccp_pci_devices[] = {
> > > { PCI_VENDOR_AMD, PCI_PRODUCT_AMD_AMD64_17_CCP_1 },
> > > { PCI_VENDOR_AMD, PCI_PRODUCT_AMD_AMD64_17_CCP_2 },
> > > { PCI_VENDOR_AMD, PCI_PRODUCT_AMD_AMD64_17_1X_CCP },
> > > + { PCI_VENDOR_AMD, PCI_PRODUCT_AMD_AMD64_17_3X_CCP },
> > > };
> > >
> > > int
> > > diff --git a/sys/dev/pci/pcidevs b/sys/dev/pci/pcidevs
> > > index d0a021b89bc..fb918e8de5d 100644
> > > --- a/sys/dev/pci/pcidevs
> > > +++ b/sys/dev/pci/pcidevs
> > > @@ -754,6 +754,7 @@ product AMD AMD64_17_CCP_2 0x1468 AMD64 17h Crypto
> > > product AMD AMD64_17_PCIE_4 0x1470 AMD64 17h PCIE
> > > product AMD AMD64_17_PCIE_5 0x1471 AMD64 17h PCIE
> > > product AMD AMD64_17_3X_RC 0x1480 AMD64 17h/3xh Root Complex
> > > +product AMD AMD64_17_3X_CCP 0x1486 AMD64 17h/3xh Crypto
> > > product AMD AMD64_14_HB 0x1510 AMD64 14h Host
> > > product AMD AMD64_14_PCIE_1 0x1512 AMD64 14h PCIE
> > > product AMD AMD64_14_PCIE_2 0x1513 AMD64 14h PCIE
> > >
> > >
>
>
