On Tue, Jan 21, 2020 at 07:23:43PM -0700, Theo de Raadt wrote: > I suspect this breaks an usage case which is not documented. > > People may be doing leave +1 to mean "1 minutes". > > % leave +1 > Alarm set for Tue Jan 21 19:23. (pid 55602) > % date > Tue Jan 21 19:22:32 MST 2020 > % Just one more minute! > > 1) it isn't documented that + can take a smaller number > 2) it will be hard to train people to use +0001
These are my concerns as well. An idea I had a while back was to drop support for +hhmm and just support +minutes, like we do with shutdown(8). The invocation would then be: usage: leave [hhmm | +minutes] so you could enforce strict string length requirements in the former case. I think typing `leave +0100` to say "remind me to leave in one hour" is pretty strange. Typing `leave +60` seems more natural. And typing `leave +5` is much better than `leave +0005`.
