On Sat, Feb 22, 2020 at 04:22:25PM +0100, Jasper Lievisse Adriaanse wrote:
> Hi,
> 
> - add an AMD product found on the APU2

I would not consider 0x7900 a root hub as it attaches to another hub

uhub2 at uhub1 port 1 configuration 1 interface 0 "Advanced Micro Devices 
product 0x7900" rev 2.00/0.18 addr 2

> - add vendor id for "Synaptics, Inc.

I'd just go with "Synaptics"

> - add synaptics fingerprint reader found on recent thinkpads; I couldn't find 
> a proper
>   name for this device in the Linux usb.ids repository so I went with the 
> generic
>   'Fingerprint Reader" that's also used elsewhere in this file.

does it not supply a string itself?

the lenovo windows driver matches on 0x06cb:0x00bd and 0x06cb:0x00c2
and calls itself "Synaptics UWP WBDI" which isn't very helpful.

> 
> OK?
> 
> Index: usbdevs
> ===================================================================
> RCS file: /cvs/src/sys/dev/usb/usbdevs,v
> retrieving revision 1.710
> diff -u -p -r1.710 usbdevs
> --- usbdevs   27 Jan 2020 15:41:42 -0000      1.710
> +++ usbdevs   22 Feb 2020 15:21:41 -0000
> @@ -262,6 +262,7 @@ vendor AGFA               0x06bd  AGFA-Gevaert
>  vendor ASIAMD                0x06be  Asia Microelectronic Development
>  vendor PHIDGETS              0x06c2  Phidgets
>  vendor BIZLINK               0x06c4  Bizlink International
> +vendor SYNAPTICS     0x06cb  Synaptics, Inc.
>  vendor KEYSPAN               0x06cd  Keyspan
>  vendor AASHIMA               0x06d6  Aashima Technology
>  vendor LIEBERT               0x06da  Liebert
> @@ -888,6 +889,9 @@ product ALTI2 NEPTUNE3            0x6001  Neptune 3
>  product AMBIT WLAN           0x0302  WLAN
>  product AMBIT NTL_250                0x6098  NTL 250 cable modem
>  
> +/* Advanced Micro Devices products */
> +product AMD HUB                      0x7900  Root Hub
> +
>  /* Amigo Technology products */
>  product AMIGO RT2870_1               0x9031  RT2870
>  product AMIGO RT2870_2               0x9041  RT2870
> @@ -4167,6 +4171,9 @@ product SWEEX2 LW153            0x0153  LW153
>  product SWEEX2 LW154         0x0154  LW154
>  product SWEEX2 LW303         0x0302  LW303
>  product SWEEX2 LW313         0x0313  LW313
> +
> +/* Synaptics, Inc. products */
> +product SYNAPTICS FPRINT     0x00bd  Fingerprint Reader
>  
>  /* Syntech Information products */
>  product SYNTECH SERIAL               0x0001  Serial
> 
> 

Reply via email to