Stefan Sperling <s...@stsp.name> wrote: > On Sun, Apr 19, 2020 at 10:46:28PM +0200, Mark Kettenis wrote: > > > Date: Sun, 19 Apr 2020 22:24:31 +0200 > > > From: Stefan Sperling <s...@stsp.name> > > > > > > We really should be documenting supported wifi chipsets to help users > > > find devices that will work with OpenBSD. > > > The bwfm(4) man page leaves such questions entirely open at present. > > > > > > The diff below intends to fill that gap by adding table which lists > > > supported devices. The table includes chipset name, supported bands, > > > MIMO config, and bus attachments. > > > > > > I have cross-checked data in my table with internet searches. Sometimes > > > I found official product sheets, but some info is based on tech press > > > articles, copies of wikidevi pages, or gleaned from kernel messages > > > posted on forums. It should be mostly accurate and much better than > > > no info at all. > > > > > > Note that some chips support bus attachments which bwfm does not > > > recognize. I have documented the bus attachments which the driver > > > actually supports, which is a subset of what the chipsets support. > > > This list will need to be kept in sync anyway whenever device support > > > in the driver is improved. > > > > > > While here, also document the hex product IDs in bwfm's sdmmc attachment > > > driver in source code comments. These hex numbers actually correspond > > > to decimal chipset numbers but that is not immediately obvious so I think > > > adding comments is warranted (of course it would be better to use macros, > > > but I'm not going to go that far in a documentation patch). > > > > > > ok? > > > > I like the comments documenting the product IDs. Don't think there is > > much value here in adding #defines actually. > > > > As for the man page, can you use "SDIO" instead of "SDMMC"? That is > > techically more correct and avoids the ugliness of leaving out the > > slash in "SD/MMC". > > Sure. I agree that SDIO is way more accurate.
% man -k sdio amlmmc(4) - Amlogic MMC/SD/SDIO controller dwmmc(4) - Synopsis DesignWare MMC/SD/SDIO controller ommmc(4/armv7) - MMC/SD/SDIO controller Oh, so it only works on those 3 controllers? I think the distinction is totally incorrect. It would be like saying EHCI or USB2.0 instead of USB. I think this should describe the bus connected to, rather than the secret sub-protocol being spoken to over the wire.
