On Mon, May 25, 2020 at 08:49:23AM -0500, Lucas Raab wrote:
> On Mon, May 25, 2020 at 09:13:43PM +1000, Jonathan Gray wrote:
> > On Sun, May 24, 2020 at 05:01:16PM -0700, jo...@armadilloaerospace.com
> > wrote:
> > > The efifb driver behaves almost identically to the inteldrm driver
> > > for wscons, but did not implement the getchar() accessops, so
> > > wsmoused would fail at startup.
> >
> > This seems reasonable, though your mail client has line wrapped the
> > patch so it won't apply. In this case it is simple enough to apply by
> > hand.
> >
> > > Separately, I increased the maximum screen dimensions to 160x50 to
> > > allow the 12x24 font to be used on an 1920 monitor, which looks great!
> >
> > Something similiar was done and reverted as it somehow broke inteldrm
> > taking the fb over from efifb on a 4k display. Perhaps someone with a
> > 4k display can confirm if this is still a problem.
> >
> > https://marc.info/?l=openbsd-bugs&m=155337866226121&w=2
> >
> > That was back before we deferred most of inteldrm to when the root fs is
> > mounted and interrupts are available. And just before the last big drm
> > update by the look of it.
>
> I tried out the patch twice, once with John's value for EFIFB_HEIGHT of
> 50 and once with the original original value of 160. The behavior of
> the bug report I submitted doesn't reappear so it looks everything is
> working as intended. This is with the same monitor as in the bug report
Thanks for testing. I've committed the wsmoused part on it's own, so
how about we try rev 1.21 again?
Index: efifb.c
===================================================================
RCS file: /cvs/src/sys/arch/amd64/amd64/efifb.c,v
retrieving revision 1.30
diff -u -p -r1.30 efifb.c
--- efifb.c 25 May 2020 14:12:04 -0000 1.30
+++ efifb.c 25 May 2020 14:20:25 -0000
@@ -115,8 +115,8 @@ const struct cfattach efifb_ca = {
sizeof(struct efifb_softc), efifb_match, efifb_attach, NULL
};
-#define EFIFB_WIDTH 100
-#define EFIFB_HEIGHT 31
+#define EFIFB_WIDTH 160
+#define EFIFB_HEIGHT 160
struct wsscreen_descr efifb_std_descr = { "std" };
