On Thu, Jun 18, 2020 at 11:41:17AM +0200, Otto Moerbeek wrote:
> On Thu, Jun 18, 2020 at 09:57:34AM +0200, Salvatore Cuzzilla wrote:
>
> > Perfect, tnx!
> >
> > On 18.06.2020 07:58, Otto Moerbeek wrote:
> > > On Wed, Jun 17, 2020 at 10:53:54PM +0200, Salvatore Cuzzilla wrote:
> > >
> > > > Hi Otto here the logs (multitail) - @22:49:15 I restarted ntpd:
> > > > -----------------------------------------------------------------------------------------
> > > > Jun 17 22:49:23 obsd ntpd[88568]: constraint reply from 188.61.106.24:
> > > > offset -0.541051
> > > > Jun 17 22:49:46 obsd ntpd[88568]: peer 172.17.1.1 now valid
> > > > 01] /var/log/daemon <---
> > > >
> > > >
> > > >
> > > > 248KB - 2020/06/17 22:49:46
> > > > -----------------------------------------------------------------------------------------
> > > > Jun 17 14:00:01 obsd syslogd[80400]: restart
> > > > Jun 17 16:19:41 obsd ntpd[92699]: pipe write error (from main): No such
> > > > file or directory
> > > > Jun 17 16:21:07 obsd ntpd[29588]: pipe write error (from main): No such
> > > > file or directory
> > > > Jun 17 17:00:01 obsd syslogd[80400]: restart
> > > > Jun 17 17:01:25 obsd ntpd[96273]: pipe write error (from main): No such
> > > > file or directory
> > > > Jun 17 17:02:38 obsd ntpd[94737]: pipe write error (from main): No such
> > > > file or directory
> > > > Jun 17 20:00:01 obsd syslogd[80400]: restart
> > > > Jun 17 22:00:01 obsd syslogd[80400]: restart
> > > > Jun 17 22:49:22 obsd ntpd[40936]: pipe write error (from main): No such
> > > > file or directory
> > > > 02] /var/log/messages <---
> > > >
> > > >
> > > >
> > > > 205KB - 2020/06/17 22:49:22
> > > > -----------------------------------------------------------------------------------------
> > > > 22:49:15 -ksh ToTo@obsd ~ $ doas rcctl restart ntpd
> > > > ntpd(ok)
> > > > ntpd(ok)
> > > > 22:49:23 -ksh ToTo@obsd ~ $
> > >
> > >
> > > OK, now we're getting somewhere. It always helps to provide lots of
> > > information form the start.
> > >
> > > The message is generated by ntpd being stopped. It is harmless,
> > > though it is actually wrong, it's a pip read error.
> > >
> > > So nothing to worry about. I'll see if the log level should be
> > > changed to debug for this one or maybe another solution.
> > >
>
> And now with diff.
I committed a slighlty more conservative version of this diff. A dns
read error (which should not happen) still logs at warn level.
-Otto
>
> Index: ntp.c
> ===================================================================
> RCS file: /cvs/src/usr.sbin/ntpd/ntp.c,v
> retrieving revision 1.164
> diff -u -p -r1.164 ntp.c
> --- ntp.c 11 Apr 2020 07:49:48 -0000 1.164
> +++ ntp.c 18 Jun 2020 09:39:03 -0000
> @@ -365,7 +365,7 @@ ntp_main(struct ntpd_conf *nconf, struct
> if (nfds > 0 && pfd[PFD_PIPE_MAIN].revents & (POLLIN|POLLERR)) {
> nfds--;
> if (ntp_dispatch_imsg() == -1) {
> - log_warn("pipe write error (from main)");
> + log_debug("pipe read error (from main)");
> ntp_quit = 1;
> }
> }
> @@ -380,7 +380,7 @@ ntp_main(struct ntpd_conf *nconf, struct
> if (nfds > 0 && pfd[PFD_PIPE_DNS].revents & (POLLIN|POLLERR)) {
> nfds--;
> if (ntp_dispatch_imsg_dns() == -1) {
> - log_warn("pipe write error (from dns engine)");
> + log_debug("pipe read error (from dns engine)");
> ntp_quit = 1;
> }
> }
>
