On Thu, Jun 25, 2020 at 06:40:36PM +0200, Solene Rapenne wrote:
> I found that ssh-keygen(1) missed mention of -a flag in SYNOPSIS.
>
i think this got accidently removed in -r1.184:
remove single letter flags for moduli operations
> The following patch adds mention to [-a rounds] with default (no
> flag), -p, -c, -K and -A
>
i'm definitely not the right person to ok that
> All the functions triggered by these flags use the rounds variable
> defined with -a parameter (default 0)
>
>
> I also propose a small wording change, in the sentence:
> "After a key is generated, instructions below detail [...]"
>
> I thought below refered to the list of options after that sentence,
> but it may be a mistake of mine here.
>
i wanted to ask about this text too. it's unclear to me. after a key is
generated, ssh-keygen asks where to save it. i wonder why we use the
wording "should be placed to be activated"? it seems odd, but maybe
there's a reason.
jmc
>
> Index: ssh-keygen.1
> ===================================================================
> RCS file: /cvs/src/usr.bin/ssh/ssh-keygen.1,v
> retrieving revision 1.203
> diff -u -p -r1.203 ssh-keygen.1
> --- ssh-keygen.1 3 Apr 2020 02:26:56 -0000 1.203
> +++ ssh-keygen.1 25 Jun 2020 16:28:54 -0000
> @@ -44,6 +44,7 @@
> .Sh SYNOPSIS
> .Nm ssh-keygen
> .Op Fl q
> +.Op Fl a Ar rounds
> .Op Fl b Ar bits
> .Op Fl C Ar comment
> .Op Fl f Ar output_keyfile
> @@ -54,6 +55,7 @@
> .Op Fl w Ar provider
> .Nm ssh-keygen
> .Fl p
> +.Op Fl a Ar rounds
> .Op Fl f Ar keyfile
> .Op Fl m Ar format
> .Op Fl N Ar new_passphrase
> @@ -71,6 +73,7 @@
> .Op Fl f Ar input_keyfile
> .Nm ssh-keygen
> .Fl c
> +.Op Fl a Ar rounds
> .Op Fl C Ar comment
> .Op Fl f Ar keyfile
> .Op Fl P Ar passphrase
> @@ -93,6 +96,7 @@
> .Op Fl f Ar known_hosts_file
> .Nm ssh-keygen
> .Fl K
> +.Op Fl a Ar rounds
> .Op Fl w Ar provider
> .Nm ssh-keygen
> .Fl R Ar hostname
> @@ -125,6 +129,7 @@
> .Op Fl f Ar input_keyfile
> .Nm ssh-keygen
> .Fl A
> +.Op Fl a Ar rounds
> .Op Fl f Ar prefix_path
> .Nm ssh-keygen
> .Fl k
> @@ -248,7 +253,9 @@ keys may be converted using this option
> .Fl p
> (change passphrase) flag.
> .Pp
> -After a key is generated, instructions below detail where the keys
> +After a key is generated,
> +.Nm
> +will ask where the keys
> should be placed to be activated.
> .Pp
> The options are as follows:
>
