> On 26 Jun 2020, at 22:00, Klemens Nanni <k...@openbsd.org> wrote:
>
> Those are global variables are (zero) initialised as such already and
> machine_init() is called only once upon startup.
>
> Feedback? OK?
>
>
> Index: machine.c
> ===================================================================
> RCS file: /cvs/src/usr.bin/top/machine.c,v
> retrieving revision 1.105
> diff -u -p -r1.105 machine.c
> --- machine.c 25 Jun 2020 20:38:41 -0000 1.105
> +++ machine.c 26 Jun 2020 17:21:18 -0000
> @@ -203,11 +203,6 @@ machine_init(struct statics *statics)
> if (cpu_online == NULL)
> err(1, NULL);
>
> - pbase = NULL;
> - pref = NULL;
> - onproc = -1;
> - nproc = 0;
> -
> /*
> * get the page size with "getpagesize" and calculate pageshift from
> * it
>
What about “pageshift = 0;” at usr.bin/top/machine.c:216 ?
