On Sat, Aug 08, 2020 at 02:45:16PM +0200, Marcus Glocker wrote: Hello Marcus,
> For now how about adding the according auto control id to our dev_ctrls > structure? In a next step we could change > dev_set_ctrl_auto_white_balance() to become a generic function > dev_set_ctrl_auto() available for all auto controls. Agreed. I like your patch, which is better than my original! My only very minor comment is whether we might want to document that it's safe to put "0" in a "V4L2_CID_AUTO" settings, since the lowest value one of those can be is 0x900 (judging by videoio.h)? At least, I had to look to make sure it was safe :) One other thing has occurred to me -- but can be done in a future patch -- is that we probably want to be able to do: $ video white_balance_temperature=auto Laurie
