On Sun, Aug 09, 2020 at 07:48:21PM +1000, Jonathan Gray wrote: > Thinking about this some more the problem is really the choice of errno. > It used to be EINVAL but was changed to EFTYPE in > > ---------------------------- > revision 1.7 > date: 1997/06/20 14:04:30; author: kstailey; state: Exp; lines: +7 -7; > Change errno cause by mounting invalid filesystems from EINVAL to EFTYPE. > ---------------------------- > > mount_msdos(8) knows about EINVAL and will print "not an MSDOS filesystem" > > On reading mount(2) EOPNOTSUPP would be suitable for when the kernel > did not have msdos support built in not when the blocks found are not > msdos. > > So either mount_msdos gains a EFTYPE case or we go back to EINVAL. Reverting EFTYPE makes sense to me and having mount_msdos say "not an MSDOS filesystem" on exFAT is an improvement.
OK kn
