Mark Kettenis <mark.kette...@xs4all.nl> writes: > The diff below fixes the way we handle named references in AML > packages. This fixes some bugs but I'd like to make sure that this > doesn't inadvertedly break things. So tests on a wide variety of > machines are welcome.
I see a prompt crash: https://photos.app.goo.gl/5NkwAHA6jxrXFzEV7 OCRed: 7b880 size Ox50 previous type ACPI (0xdeaf4151 = 0xdeaf4152) Stopped at db_enter+0x10: : pop %rbp TID PID UID PR FLAGS PFLAGS 0x10000 0x200 CPU COMMAND 0K swapper db_enter(10, ffffffff8251cf10,282,8, ffffffff81887a30, ffffffff8251cf18) at db_ enter +0x10 panic(ffffffff81dd9174, ffffffff81dd9174, 3f, ffffffff8le23d0e, ffff80080807b888,9) at panic+0x12a malloc(50,21,9,50,69ffcbe5966771e0, ffff80000010d488) at malloc+0x783 aml_parse(ffff88000010d488,69, ffff80000003a810, ffff80000010d488, ee7eae2dea48b7a 4, ffff80000010d488) at aml_parse+0x2a32 aml_parse(ffff80000010d488, 54,0,ffff80008818d488, ee?eae2dea 4983ef,ffff80880818d488) at aml_parse+0x3bc aml_eval(ffff800000176f88, ffff808088082108, 74, 180200001, 8, ffff800888176f88) at aml_eval+0x317 aml_parse(ffff800000176f88, 74, 7d, ffff800000176f88, ee?eae2dea 48b7a4, ffff89800017 6f88) at aml_parse+0x2df6 aml_parse(ffff808080176f88,54, ffff800008176f88, ffff880000176f88, ee7eae2dea4983e, fffff800000176f88) at aml_parse+8x3bc aml_eval(0, ffff800000081a08, 74,0,0,0) at aml_eval+0x317 aml_evalnode(ffff880000008202c, ffff800000082008,8,0, ffffffff8251d648,ffff8808088 8202c) at aml_evalnode +0xb4 aml_evalinteger(ffff80000002e400, ffff800000082c88, ffffffff81ddbf04,8,8, ffffffff 8251d6f0) at aml_evalinteger+0x4e acpitz_gettempreading(ffff800000257800, ffffffff81ddbf04, dad3d43216419857, ffffff ff8251d73b, ffff800000257800, aac) at acpitz_gettempreading +0x37 acpitz_attach(ffff80000002e400, ffff800000257800, ffffffff8251d818, ffff80000002e4 08,44b6122d7f8019d2, ffff80000002e480) at acpitz_attach+Oxlea config_attach(ffff800000028400, ffffffff8210ef70, ffffffff82510818, ffffffff817576 40,68aa0891922ad23e, ffff800000082c88) at config_attach+8x1f4 end trace frame: 0xffffffff8251d950, count: 0 The contents of cp -R /var/db/acpi /tmp && iasl -d /tmp/acpi/* are here: https://blackgnezdo.github.io/hp-elitebook-840.tgz dmesg when not running your patch: OpenBSD 6.8-current (GENERIC.MP) #69: Mon Nov 30 19:53:29 PST 2020 g...@hippy.nest.cx:/usr/src/sys/arch/amd64/compile/GENERIC.MP real mem = 17055608832 (16265MB) avail mem = 16523407360 (15757MB) random: good seed from bootblocks mpath0 at root scsibus0 at mpath0: 256 targets mainbus0 at root bios0 at mainbus0: SMBIOS rev. 2.7 @ 0xbbe3f000 (33 entries) bios0: vendor Hewlett-Packard version "L71 Ver. 01.20" date 07/28/2014 bios0: Hewlett-Packard HP EliteBook 840 G1 acpi0 at bios0: ACPI 5.0 acpi0: sleep states S0 S3 S4 S5 acpi0: tables DSDT FACP HPET APIC MCFG TCPA SSDT SSDT FPDT BGRT SSDT SSDT SSDT SSDT SSDT ASF! DMAR acpi0: wakeup devices LANC(S5) EHC1(S3) XHC_(S3) PCIB(S5) NIC_(S5) RP04(S5) WNIC(S5) acpitimer0 at acpi0: 3579545 Hz, 24 bits acpihpet0 at acpi0: 14318179 Hz acpimadt0 at acpi0 addr 0xfee00000: PC-AT compat cpu0 at mainbus0: apid 0 (boot processor) cpu0: Intel(R) Core(TM) i7-4600U CPU @ 2.10GHz, 1995.70 MHz, 06-45-01 cpu0: FPU,VME,DE,PSE,TSC,MSR,PAE,MCE,CX8,APIC,SEP,MTRR,PGE,MCA,CMOV,PAT,PSE36,CFLUSH,DS,ACPI,MMX,FXSR,SSE,SSE2,SS,HTT,TM,PBE,SSE3,PCLMUL,DTES64,MWAIT,DS-CPL,VMX,SMX,EST,TM2,SSSE3,SDBG,FMA3,CX16,xTPR,PDCM,PCID,SSE4.1,SSE4.2,x2APIC,MOVBE,POPCNT,DEADLINE,AES,XSAVE,AVX,F16C,RDRAND,NXE,PAGE1GB,RDTSCP,LONG,LAHF,ABM,PERF,ITSC,FSGSBASE,TSC_ADJUST,BMI1,AVX2,SMEP,BMI2,ERMS,INVPCID,SRBDS_CTRL,MD_CLEAR,IBRS,IBPB,STIBP,L1DF,SSBD,SENSOR,ARAT,XSAVEOPT,MELTDOWN cpu0: 256KB 64b/line 8-way L2 cache cpu0: smt 0, core 0, package 0 mtrr: Pentium Pro MTRR support, 10 var ranges, 88 fixed ranges cpu0: apic clock running at 99MHz cpu0: mwait min=64, max=64, C-substates=0.2.1.2.4.1.1.1, IBE cpu1 at mainbus0: apid 1 (application processor) cpu1: Intel(R) Core(TM) i7-4600U CPU @ 2.10GHz, 1995.39 MHz, 06-45-01 cpu1: FPU,VME,DE,PSE,TSC,MSR,PAE,MCE,CX8,APIC,SEP,MTRR,PGE,MCA,CMOV,PAT,PSE36,CFLUSH,DS,ACPI,MMX,FXSR,SSE,SSE2,SS,HTT,TM,PBE,SSE3,PCLMUL,DTES64,MWAIT,DS-CPL,VMX,SMX,EST,TM2,SSSE3,SDBG,FMA3,CX16,xTPR,PDCM,PCID,SSE4.1,SSE4.2,x2APIC,MOVBE,POPCNT,DEADLINE,AES,XSAVE,AVX,F16C,RDRAND,NXE,PAGE1GB,RDTSCP,LONG,LAHF,ABM,PERF,ITSC,FSGSBASE,TSC_ADJUST,BMI1,AVX2,SMEP,BMI2,ERMS,INVPCID,SRBDS_CTRL,MD_CLEAR,IBRS,IBPB,STIBP,L1DF,SSBD,SENSOR,ARAT,XSAVEOPT,MELTDOWN cpu1: 256KB 64b/line 8-way L2 cache cpu1: smt 1, core 0, package 0 cpu2 at mainbus0: apid 2 (application processor) cpu2: Intel(R) Core(TM) i7-4600U CPU @ 2.10GHz, 1995.40 MHz, 06-45-01 cpu2: FPU,VME,DE,PSE,TSC,MSR,PAE,MCE,CX8,APIC,SEP,MTRR,PGE,MCA,CMOV,PAT,PSE36,CFLUSH,DS,ACPI,MMX,FXSR,SSE,SSE2,SS,HTT,TM,PBE,SSE3,PCLMUL,DTES64,MWAIT,DS-CPL,VMX,SMX,EST,TM2,SSSE3,SDBG,FMA3,CX16,xTPR,PDCM,PCID,SSE4.1,SSE4.2,x2APIC,MOVBE,POPCNT,DEADLINE,AES,XSAVE,AVX,F16C,RDRAND,NXE,PAGE1GB,RDTSCP,LONG,LAHF,ABM,PERF,ITSC,FSGSBASE,TSC_ADJUST,BMI1,AVX2,SMEP,BMI2,ERMS,INVPCID,SRBDS_CTRL,MD_CLEAR,IBRS,IBPB,STIBP,L1DF,SSBD,SENSOR,ARAT,XSAVEOPT,MELTDOWN cpu2: 256KB 64b/line 8-way L2 cache cpu2: smt 0, core 1, package 0 cpu3 at mainbus0: apid 3 (application processor) cpu3: Intel(R) Core(TM) i7-4600U CPU @ 2.10GHz, 1995.39 MHz, 06-45-01 cpu3: FPU,VME,DE,PSE,TSC,MSR,PAE,MCE,CX8,APIC,SEP,MTRR,PGE,MCA,CMOV,PAT,PSE36,CFLUSH,DS,ACPI,MMX,FXSR,SSE,SSE2,SS,HTT,TM,PBE,SSE3,PCLMUL,DTES64,MWAIT,DS-CPL,VMX,SMX,EST,TM2,SSSE3,SDBG,FMA3,CX16,xTPR,PDCM,PCID,SSE4.1,SSE4.2,x2APIC,MOVBE,POPCNT,DEADLINE,AES,XSAVE,AVX,F16C,RDRAND,NXE,PAGE1GB,RDTSCP,LONG,LAHF,ABM,PERF,ITSC,FSGSBASE,TSC_ADJUST,BMI1,AVX2,SMEP,BMI2,ERMS,INVPCID,SRBDS_CTRL,MD_CLEAR,IBRS,IBPB,STIBP,L1DF,SSBD,SENSOR,ARAT,XSAVEOPT,MELTDOWN cpu3: 256KB 64b/line 8-way L2 cache cpu3: smt 1, core 1, package 0 ioapic0 at mainbus0: apid 0 pa 0xfec00000, version 20, 40 pins acpimcfg0 at acpi0 acpimcfg0: addr 0xe0000000, bus 0-255 acpiprt0 at acpi0: bus 0 (PCI0) acpiprt1 at acpi0: bus -1 (PEGP) acpiprt2 at acpi0: bus 1 (RP01) acpiprt3 at acpi0: bus 2 (RP04) acpiprt4 at acpi0: bus 3 (RP06) acpiprt5 at acpi0: bus -1 (RP07) acpiprt6 at acpi0: bus -1 (RP08) acpiec0 at acpi0 "HPQ6001" at acpi0 not configured acpipci0 at acpi0 PCI0: 0x00000010 0x00000011 0x00000000 acpicmos0 at acpi0 "PNP0A06" at acpi0 not configured "SYN3003" at acpi0 not configured "HPQ6007" at acpi0 not configured acpibat0 at acpi0: BAT0 model "Primary" serial 41076 2014/09/16 type LIon oem "Hewlett-Packard" acpibat1 at acpi0: BAT1 not present acpiac0 at acpi0: AC unit online acpibtn0 at acpi0: SLPB acpibtn1 at acpi0: LID_ "PNP0C14" at acpi0 not configured tpm0 at acpi0 GTPM addr 0xfed40000/0x5000, Infineon SLB9635 1.2 rev 0x10 "INT33A0" at acpi0 not configured acpicpu0 at acpi0: C3(200@506 mwait.1@0x60), C2(200@148 mwait.1@0x33), C1(1000@1 mwait.1), PSS acpicpu1 at acpi0: C3(200@506 mwait.1@0x60), C2(200@148 mwait.1@0x33), C1(1000@1 mwait.1), PSS acpicpu2 at acpi0: C3(200@506 mwait.1@0x60), C2(200@148 mwait.1@0x33), C1(1000@1 mwait.1), PSS acpicpu3 at acpi0: C3(200@506 mwait.1@0x60), C2(200@148 mwait.1@0x33), C1(1000@1 mwait.1), PSS acpipwrres0 at acpi0: APPR, resource for HDEF acpipwrres1 at acpi0: COMP, resource for COM1 acpipwrres2 at acpi0: LPP_, resource for LPT0 acpipwrres3 at acpi0: PXP6, resource for RP06 acpitz0 at acpi0: critical temperature is 128 degC acpitz1 at acpi0: critical temperature is 128 degC acpitz2 at acpi0: critical temperature is 128 degC acpitz3 at acpi0: critical temperature is 128 degC acpitz4 at acpi0: critical temperature is 128 degC acpitz5 at acpi0: critical temperature is 128 degC acpitz6 at acpi0: critical temperature is 128 degC acpitz7 at acpi0: critical temperature is 128 degC acpivideo0 at acpi0: GFX0 acpivout0 at acpivideo0: DD01 cpu0: using VERW MDS workaround (except on vmm entry) cpu0: Enhanced SpeedStep 1995 MHz: speeds: 2701, 2700, 2600, 2400, 2300, 2100, 2000, 1800, 1700, 1600, 1400, 1300, 1100, 1000, 800, 756 MHz pci0 at mainbus0 bus 0 pchb0 at pci0 dev 0 function 0 "Intel Core 4G Host" rev 0x0b inteldrm0 at pci0 dev 2 function 0 "Intel HD Graphics" rev 0x0b drm0 at inteldrm0 inteldrm0: msi, HASWELL, gen 7 azalia0 at pci0 dev 3 function 0 "Intel Core 4G HD Audio" rev 0x0b: msi azalia0: No codecs found xhci0 at pci0 dev 20 function 0 "Intel 8 Series xHCI" rev 0x04: msi, xHCI 1.0 usb0 at xhci0: USB revision 3.0 uhub0 at usb0 configuration 1 interface 0 "Intel xHCI root hub" rev 3.00/1.00 addr 1 "Intel 8 Series MEI" rev 0x04 at pci0 dev 22 function 0 not configured em0 at pci0 dev 25 function 0 "Intel I218-LM" rev 0x04: msi, address azalia1 at pci0 dev 27 function 0 "Intel 8 Series HD Audio" rev 0x04: msi azalia1: codecs: IDT/0x76e0 audio0 at azalia1 ppb0 at pci0 dev 28 function 0 "Intel 8 Series PCIE" rev 0xe4 pci1 at ppb0 bus 1 ppb1 at pci0 dev 28 function 3 "Intel 8 Series PCIE" rev 0xe4: msi pci2 at ppb1 bus 2 iwm0 at pci2 dev 0 function 0 "Intel Dual Band Wireless AC 7260" rev 0x73, msi ppb2 at pci0 dev 28 function 5 "Intel 8 Series PCIE" rev 0xe4: msi pci3 at ppb2 bus 3 ehci0 at pci0 dev 29 function 0 "Intel 8 Series USB" rev 0x04: apic 0 int 17 usb1 at ehci0: USB revision 2.0 uhub1 at usb1 configuration 1 interface 0 "Intel EHCI root hub" rev 2.00/1.00 addr 1 pcib0 at pci0 dev 31 function 0 "Intel 8 Series LPC" rev 0x04 ahci0 at pci0 dev 31 function 2 "Intel 8 Series AHCI" rev 0x04: msi, AHCI 1.3 ahci0: port 0: 6.0Gb/s scsibus1 at ahci0: 32 targets sd0 at scsibus1 targ 0 lun 0: <ATA, INTEL SSDSC2BF18, LH6i> naa.55cd2e404b57893b sd0: 171705MB, 512 bytes/sector, 351651888 sectors, thin ichiic0 at pci0 dev 31 function 3 "Intel 8 Series SMBus" rev 0x04: apic 0 int 18 iic0 at ichiic0 iic0: addr 0x2c 80=04 81=04 82=04 83=04 84=04 85=04 86=04 87=04 fd=01 words 00=ffff 01=ffff 02=ffff 03=ffff 04=ffff 05=ffff 06=ffff 07=ffff spdmem0 at iic0 addr 0x50: 8GB DDR3 SDRAM PC3-12800 SO-DIMM spdmem1 at iic0 addr 0x52: 8GB DDR3 SDRAM PC3-12800 SO-DIMM isa0 at pcib0 isadma0 at isa0 pckbc0 at isa0 port 0x60/5 irq 1 irq 12 pckbd0 at pckbc0 (kbd slot) wskbd0 at pckbd0: console keyboard pms0 at pckbc0 (aux slot) wsmouse0 at pms0 mux 0 pcppi0 at isa0 port 0x61 spkr0 at pcppi0 vmm0 at mainbus0: VMX/EPT vscsi0 at root scsibus2 at vscsi0: 256 targets softraid0 at root scsibus3 at softraid0: 256 targets root on sd0a (86a971afbc66ee3f.a) swap on sd0b dump on sd0b
