On Tue, Mar 23, 2021 at 11:26:19AM GMT, Klemens Nanni wrote:
> On Tue, Mar 23, 2021 at 02:00:43AM +0100, Ulf Brosziewski wrote:
> > On 3/22/21 10:19 PM, Klemens Nanni wrote:
> > > On Mon, Mar 22, 2021 at 08:18:45PM +0100, Klemens Nanni wrote:
> > >> I was too stupid to look at `wsconsctl' output (which needs root) and
> > >> only looked here.
> > >>
> > >> Mailing the diff for my lack of better wording, plus the knob atually
> > >> takes three values which I have yet to decode by reading wsconsctl(8)
> > >> code.
> > > The reason I had to look is because the (default) functionality does not
> > > work reliably at all:
> > > 
> > >   $ doas wsconsctl mouse.tp.tapping=1
> > >   mouse.tp.tapping -> 1,3,2
> > > 
> > > Single taps are always detected reliably and deliver left mouse button
> > > clicks, but tripple and double taps for middle and right mouse button
> > > clicks work are recognised so poorly that I first though multitouch
> > > support wasn't there at all.

Hi Klemens,

According to wsmouse(4), the orders is as follows:

        This list of three parameters configures these mappings,
        in the order:

                   one-finger,two-finger,three-finger

        Setting a parameter to a positive value enables that tap
        gesture and maps it to the given mouse button.  To disable
        all three tap gestures at once, provide the single value
        of 0.  Conversely, a single non-zero value will enable
        one-finger, two-finger, and three-finger tap gestures with
        their default mappings of left button, right button, and
        middle button, respectively.

Your updated patch reads:

        #mouse.tp.tapping=0     # 1,3,2=interpret one/three/two (simultaneous) 
                                # tap(s) as left/middle/right mouse button click

Whilst technically correct, if I'm reading the man page correctly,
it is a little bit confusing as the gestures are out of order and
the digits look like they represent the number of fingers when, in
reality, they represent the mouse *buttons* so, unless I got totally
confused by either of the above, or am missing something altogether,
the patch should probably read:

        #mouse.tp.tapping=1     # 1,3,2=interpret one/two/three (simultaneous) 
                                # tap(s) as left/right/middle mouse button click

As it is clear that digits do not map to numerals.

Regards,

Raf

> > Can you tell whether that's a hardware or a driver problem?
> I'd assume it's a driver a problem since I get the exact same behaviour
> on both a Pinebook Pro and a Thinkpad X230.
> 
> > wsmouse logging might be helpful here. You could enable it by
> >     $ doas wsconsctl mouse.param=256:1,257:1
> > , make a few two-finger taps, and deactivate it with
> >     $ doas wsconsctl mouse.param=256:0,257:0
> > For the output:
> >     $ grep 'wsmouse0-' /var/log/messages
> Thanks!  Here goes the Pinebook Pro:
> 
> One-finger tap:
>       [wsmouse0-in][4275] abs:636,444 mt:0x01:0
>       [wsmouse0-in][4556] mt:0x00:-1
> 
> Two-finger tap:
>       [wsmouse0-in][0319] abs:786,516 mt:0x01:0
>       [wsmouse0-in][0329] mt:0x03:0
>       [wsmouse0-in][0772] abs:652,270 mt:0x02:1
> 
> Three-finger tap:
>       [wsmouse0-in][8821] abs:942,561 mt:0x01:0
>       [wsmouse0-in][8831] mt:0x03:0
>       [wsmouse0-in][8842] mt:0x07:0
>       [wsmouse0-in][8852] abs:942,563
>       [wsmouse0-in][9434] mt:0x05:0
>       [wsmouse0-in][9455] abs:539,210 mt:0x04:2
> 
> Only the one-finger tap does a left click, the others do nothing.
> 
> Double two-finger tap:
>       [wsmouse0-in][1894] abs:740,312 mt:0x01:0
>       [wsmouse0-in][1894] mt:0x03:0
>       [wsmouse0-in][2035] abs:554,44 mt:0x02:1
>       [wsmouse0-in][2045] mt:0x00:-1
>       [wsmouse0-ev][2045] 5:2 18:0
>       [wsmouse0-in][2055] abs:744,344 mt:0x01:0
>       [wsmouse0-ev][2055] 4:2 18:0
>       [wsmouse0-in][2065] mt:0x03:0
>       [wsmouse0-in][2497] abs:555,67 mt:0x02:1
> 
> This delivers a right-click in almost all attempts (this is the log of a
> successful one).
> 
> Touble three-finger tap:
> 
>       [wsmouse0-in][7276] abs:1114,734 mt:0x01:0
>       [wsmouse0-in][7286] mt:0x03:0
>       [wsmouse0-in][7296] mt:0x07:0
>       [wsmouse0-in][7427] abs:769,543 mt:0x06:1
>       [wsmouse0-in][7437] abs:468,284 mt:0x04:2
>       [wsmouse0-in][7437] mt:0x00:-1
>       [wsmouse0-ev][7437] 5:1 18:0
>       [wsmouse0-in][7447] abs:476,238 mt:0x01:0
>       [wsmouse0-ev][7447] 4:1 18:0
>       [wsmouse0-in][7457] abs:476,239
>       [wsmouse0-in][7467] mt:0x03:0
>       [wsmouse0-in][7477] mt:0x07:0
>       [wsmouse0-in][7648] abs:1121,718 mt:0x06:1
>       [wsmouse0-in][7658] abs:761,521 mt:0x04:2
> 
> This practically never delivers a middle click except when I'm lucky
> (this is the log of a successful one).
> 
>       [wsmouse0-in][0238] abs:1113,661 mt:0x01:0
>       [wsmouse0-in][0248] mt:0x03:0
>       [wsmouse0-in][0258] mt:0x07:0
>       [wsmouse0-in][0399] mt:0x05:0
>       [wsmouse0-in][0399] mt:0x01:0
>       [wsmouse0-in][0429] mt:0x03:0
>       [wsmouse0-in][0439] mt:0x07:0
>       [wsmouse0-in][0549] mt:0x05:0
>       [wsmouse0-in][0580] abs:453,213 mt:0x04:2
> 
> For completeness, here are a few logs, all show failed double
> three(3)-finger tap, i.e. none of them emitted a middle click;  tested
> by selecting text and trying to paste it into firefox's URL bar with the
> "scroll wheel click":
> 
>       [wsmouse0-in][0238] abs:1113,661 mt:0x01:0
>       [wsmouse0-in][0248] mt:0x03:0
>       [wsmouse0-in][0258] mt:0x07:0
>       [wsmouse0-in][0399] mt:0x05:0
>       [wsmouse0-in][0399] mt:0x01:0
>       [wsmouse0-in][0429] mt:0x03:0
>       [wsmouse0-in][0439] mt:0x07:0
>       [wsmouse0-in][0549] mt:0x05:0
>       [wsmouse0-in][0580] abs:453,213 mt:0x04:2
>       [wsmouse0-in][0590] mt:0x00:-1
> 
>       [wsmouse0-in][1102] abs:979,692 mt:0x01:0
>       [wsmouse0-in][1112] mt:0x03:0
>       [wsmouse0-in][1122] mt:0x07:0
>       [wsmouse0-in][1283] mt:0x05:0
>       [wsmouse0-in][1333] mt:0x07:0
>       [wsmouse0-in][1504] mt:0x05:0
>       [wsmouse0-in][1514] mt:0x01:0
> 
>       [wsmouse0-in][8565] abs:419,279 mt:0x01:0
>       [wsmouse0-in][8616] mt:0x00:-1
>       [wsmouse0-ev][8616] 5:0 18:0
>       [wsmouse0-ev][8797] 4:0 18:0
>       [wsmouse0-in][8837] abs:1073,709 mt:0x01:0
>       [wsmouse0-in][8847] mt:0x03:0
>       [wsmouse0-in][8857] mt:0x07:0
>       [wsmouse0-in][9058] mt:0x05:0
>       [wsmouse0-in][9098] abs:1074,709
>       [wsmouse0-in][9098] mt:0x07:0
>       [wsmouse0-in][9118] abs:1075,710
>       [wsmouse0-in][9138] abs:1076,710
>       [wsmouse0-in][9168] abs:1077,711
>       [wsmouse0-in][9289] abs:745,521 mt:0x06:1
>       [wsmouse0-in][9299] abs:421,232 mt:0x04:2
> 
>       [wsmouse0-in][7097] abs:951,686 mt:0x01:0
>       [wsmouse0-in][7107] mt:0x03:0
>       [wsmouse0-in][7117] mt:0x07:0
>       [wsmouse0-in][7308] mt:0x03:0
>       [wsmouse0-in][7318] abs:633,494 mt:0x02:1
>       [wsmouse0-in][7318] mt:0x00:-1
>       [wsmouse0-in][7328] abs:931,628 mt:0x01:0
>       [wsmouse0-in][7339] mt:0x03:0
>       [wsmouse0-in][7349] mt:0x07:0
>       [wsmouse0-in][7570] abs:627,421 mt:0x06:1
>       [wsmouse0-in][7580] abs:347,137 mt:0x04:2
> 

Reply via email to