thanks! happy to include the trailing comma (was already wondering
myself why it had not been there before).
Index: azalia.c
===================================================================
RCS file: /cvs/src/sys/dev/pci/azalia.c,v
retrieving revision 1.259
diff -u -p -u -p -r1.259 azalia.c
--- azalia.c 25 Oct 2020 07:22:06 -0000 1.259
+++ azalia.c 21 Apr 2021 08:44:32 -0000
@@ -490,7 +490,8 @@ azalia_configure_pci(azalia_t *az)
const struct pci_matchid azalia_pci_devices[] = {
{ PCI_VENDOR_INTEL, PCI_PRODUCT_INTEL_200SERIES_U_HDA },
- { PCI_VENDOR_INTEL, PCI_PRODUCT_INTEL_300SERIES_U_HDA }
+ { PCI_VENDOR_INTEL, PCI_PRODUCT_INTEL_300SERIES_U_HDA },
+ { PCI_VENDOR_INTEL, PCI_PRODUCT_INTEL_400SERIES_CAVS },
};
int
> On Apr 21, 2021, at 6:48, Greg Steuck <[email protected]> wrote:
>
> A nit below.
>
> Alexandre Ratchov <[email protected]> writes:
>
>> On Thu, Apr 15, 2021 at 03:24:56PM +0200, Ivo Sbalzarini wrote:
>> Thanks for looking at this. Few comments:
>>
>> - the "PCI_VENDOR(this->subid) == PCI_VENDOR_LENOVO" compares the 16
>> lower bits of the subid. It's not necessary because below we compare
>> the full 32 bits.
>>
>> - the "name" field is the codec name; it is identified by the "vid"
>> field, so it shouldn't depend on the device subid.
>>
>> - style: indentation is (8 char) TAB, see style(9).
>>
>> With above tweaks, I ended up this diff. Could you confirm it still
>> makes audio work?
>>
>> Index: azalia.c
>> ===================================================================
>> RCS file: /cvs/src/sys/dev/pci/azalia.c,v
>> retrieving revision 1.259
>> diff -u -p -u -p -r1.259 azalia.c
>> --- azalia.c 25 Oct 2020 07:22:06 -0000 1.259
>> +++ azalia.c 19 Apr 2021 15:37:32 -0000
>> @@ -490,7 +490,8 @@ azalia_configure_pci(azalia_t *az)
>>
>> const struct pci_matchid azalia_pci_devices[] = {
>> { PCI_VENDOR_INTEL, PCI_PRODUCT_INTEL_200SERIES_U_HDA },
>> - { PCI_VENDOR_INTEL, PCI_PRODUCT_INTEL_300SERIES_U_HDA }
>> + { PCI_VENDOR_INTEL, PCI_PRODUCT_INTEL_300SERIES_U_HDA },
>> + { PCI_VENDOR_INTEL, PCI_PRODUCT_INTEL_400SERIES_CAVS }
>
> We can save the next person a comma-modifying patch next time by adding
> a trailing comma before }. There was a discussion of this style some
> time last summer.
>
> Thanks
> Greg
