Hi, I just committed some changes to ssh/sshd configuration parsing that have been in snaps for the last few days. These changes switch parsing from using a naive tokeniser to one that better follows shell-style rules for quoting and comments.
This does make config parsing stricter in a number of cases, e.g. it was previously possible for sshd_config to have a AllowUsers option alone on a line with no arguments (it was pretty nonsensical to do so, since it had zero effect), but the new parser will reject this as well as a few other weird cases. The benefits of the new code are better handling of quoted strings, e.g. with escaped quotes and a fix for a regression caused by adding support for comments in ssh_config a few releases ago. These changes do touch something that is likely used in ways that I haven't thought of and the regress tests don't cover :) If you spot weirdness, regressions or your previously-valid configurations do not parse afterwards, then please let let bugs@ or openssh@ know ASAP. Thanks, Damien
