On Thu, 14 Oct 2021 01:15:56 +0200, Mark Kettenis wrote: > Currently the lib/libm/msun/run-lrint_test regress fails on powerpc64 > and other platforms. Our implementation came from NetBSD, but NetBSD > switched to the implementation from FreeBSD some time ago. That is > the same implementation that we already use for lrintl(3) and > llrintl(3). > > Diff below makes us use that implementation for lrint(3), lrintf(3), > llrint(3) and llrintf(3) as well. This makes the regress test pass on > powerpc64.
Doesn't this mean we end up with three copies of what is essentially the same code in s_lrint.c, s_lrintf.c and s_lrintl.c? I know it's not much but why not just move the actual code to s_lrint.c and include that in the others? - todd
