Re: upd(4) page fault since 7.0

[Anton Lindqvist]

On Fri, Oct 29, 2021 at 08:56:36AM +0200, Damien Couderc wrote:
> Le 28/10/2021 à 21:09, Anton Lindqvist a écrit :
> 
> 
> Hi Anton,
> 
> It works great!
> 
> See below the resulting dmesg with option UPD_DEBUG.
> 
> Any chance this fix will come through syspatch?

I just committed a slightly tweaked version as
UHIDEV_CLAIM_MULTIPLE_REPORTID can be defined to 256 to avoid the
conflict according to the USB HID specification.

This will soon be available in -current snapshots.

Index: dev/usb/uhidev.h
===================================================================
RCS file: /cvs/src/sys/dev/usb/uhidev.h,v
retrieving revision 1.32
diff -u -p -r1.32 uhidev.h
--- dev/usb/uhidev.h    12 Sep 2021 06:58:08 -0000      1.32
+++ dev/usb/uhidev.h    29 Oct 2021 15:35:43 -0000
@@ -80,9 +80,9 @@ struct uhidev {
 struct uhidev_attach_arg {
        struct usb_attach_arg   *uaa;
        struct uhidev_softc     *parent;
-       uint8_t                  reportid;
-#define        UHIDEV_CLAIM_MULTIPLE_REPORTID  255
-       uint8_t                  nreports;
+       u_int                    reportid;
+#define        UHIDEV_CLAIM_MULTIPLE_REPORTID  256
+       u_int                    nreports;
        uint8_t                 *claimed;
 };